[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/6] migration: ram_release_pages() always receive 1 page
From: |
Peter Xu |
Subject: |
Re: [PATCH v2 3/6] migration: ram_release_pages() always receive 1 page as argument |
Date: |
Fri, 24 Dec 2021 15:24:55 +0800 |
On Tue, Dec 21, 2021 at 01:52:32PM +0100, Juan Quintela wrote:
> -static void ram_release_pages(const char *rbname, uint64_t offset, int pages)
> +static void ram_release_page(const char *rbname, uint64_t offset)
> {
> if (!migrate_release_ram() || !migration_in_postcopy()) {
> return;
> }
>
> - ram_discard_range(rbname, offset, ((ram_addr_t)pages) <<
> TARGET_PAGE_BITS);
> + ram_discard_range(rbname, offset, 1ULL << TARGET_PAGE_BITS);
This is TARGET_PAGE_SIZE, afaict.. anyway,
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH v2 0/6] migration: misc cleanups, Juan Quintela, 2021/12/21
- [PATCH v2 1/6] migration: All this fields are unsigned, Juan Quintela, 2021/12/21
- [PATCH v2 2/6] migration: We only need last_stage in two places, Juan Quintela, 2021/12/21
- [PATCH v2 3/6] migration: ram_release_pages() always receive 1 page as argument, Juan Quintela, 2021/12/21
- Re: [PATCH v2 3/6] migration: ram_release_pages() always receive 1 page as argument,
Peter Xu <=
- [PATCH v2 4/6] migration: Remove masking for compression, Juan Quintela, 2021/12/21
- [PATCH v2 5/6] migration: simplify do_compress_ram_page, Juan Quintela, 2021/12/21
- [PATCH v2 6/6] migration: Move ram_release_pages() call to save_zero_page_to_file(), Juan Quintela, 2021/12/21