|
From: | Emanuele Giuseppe Esposito |
Subject: | Re: [RFC PATCH v2 11/14] block_job_query: remove atomic read |
Date: | Thu, 23 Dec 2021 12:37:55 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 18/12/2021 13:07, Vladimir Sementsov-Ogievskiy wrote:
04.11.2021 17:53, Emanuele Giuseppe Esposito wrote:Not sure what the atomic here was supposed to do, since job.busy is protected by the job lock.In block_job_query() it is protected only since previous commit. So, before previous commit, atomic read make sense.
To me it doesn't really, because it is protected with job_lock/unlock in job.c, and here is read with an atomic. But maybe I am missing something.
Hmm. but job_lock() is still a no-op at this point. So, actually, it would be more correct to drop this qatomic_read after patch 14.
Will do. Thank you, Emanuele
[Prev in Thread] | Current Thread | [Next in Thread] |