[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v7 11/13] target/hexagon: call idef-parser functions
From: |
Taylor Simpson |
Subject: |
RE: [PATCH v7 11/13] target/hexagon: call idef-parser functions |
Date: |
Wed, 22 Dec 2021 23:21:19 +0000 |
> -----Original Message-----
> From: Anton Johansson <anjo@rev.ng>
> Sent: Friday, December 17, 2021 2:01 AM
> To: qemu-devel@nongnu.org
> Cc: ale@rev.ng; Taylor Simpson <tsimpson@quicinc.com>; Brian Cain
> <bcain@quicinc.com>; babush@rev.ng; nizzo@rev.ng;
> richard.henderson@linaro.org
> Subject: [PATCH v7 11/13] target/hexagon: call idef-parser functions
>
> From: Alessandro Di Federico <ale@rev.ng>
>
> Extend gen_tcg_funcs.py in order to emit calls to the functions emitted by
> the idef-parser, if available. An option is also added to fully disable the
> output of the idef-parser, which is useful for debugging purposes.
>
> Signed-off-by: Alessandro Di Federico <ale@rev.ng>
> Signed-off-by: Anton Johansson <anjo@rev.ng>
> Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
> diff --git a/target/hexagon/gen_tcg_funcs.py
> b/target/hexagon/gen_tcg_funcs.py index 1fd9de95d5..0ea89d1ed7 100755
> --- a/target/hexagon/gen_tcg_funcs.py
> +++ b/target/hexagon/gen_tcg_funcs.py
> hex_common.calculate_attribs()
> + ## Whether or not idef-parser is enabled is
> + ## determined by the number of arguments to
> + ## this script:
> + ##
> + ## 5 args. -> not enabled,
> + ## 6 args. -> idef-parser enabled.
> + ##
> + ## The 6:th arg. then holds a list of the successfully
> + ## parsed instructions.
> + if len(sys.argv) > 6:
> + hex_common.read_idef_parser_enabled_file(sys.argv[5])
> tagregs = hex_common.get_tagregs()
> tagimms = hex_common.get_tagimms()
>
> - with open(sys.argv[5], 'w') as f:
> + output_file = sys.argv[-1]
> + with open(output_file, 'w') as f:
> f.write("#ifndef HEXAGON_TCG_FUNCS_H\n")
> f.write("#define HEXAGON_TCG_FUNCS_H\n\n")
> + f.write("#include \"idef-generated-emitter.h.inc\"\n\n")
This should be conditional on the number of arguments to this script
- [PATCH v7 00/13] target/hexagon: introduce idef-parser, Anton Johansson, 2021/12/17
- [PATCH v7 02/13] target/hexagon: import README for idef-parser, Anton Johansson, 2021/12/17
- [PATCH v7 08/13] target/hexagon: import flex/bison to docker files, Anton Johansson, 2021/12/17
- [PATCH v7 09/13] target/hexagon: import lexer for idef-parser, Anton Johansson, 2021/12/17
- [PATCH v7 04/13] target/hexagon: make helper functions non-static, Anton Johansson, 2021/12/17
- [PATCH v7 03/13] target/hexagon: make slot number an unsigned, Anton Johansson, 2021/12/17
- [PATCH v7 11/13] target/hexagon: call idef-parser functions, Anton Johansson, 2021/12/17
- RE: [PATCH v7 11/13] target/hexagon: call idef-parser functions,
Taylor Simpson <=
- [PATCH v7 06/13] target/hexagon: expose next PC in DisasContext, Anton Johansson, 2021/12/17
- [PATCH v7 05/13] target/hexagon: introduce new helper functions, Anton Johansson, 2021/12/17
- [PATCH v7 07/13] target/hexagon: prepare input for the idef-parser, Anton Johansson, 2021/12/17
- [PATCH v7 01/13] target/hexagon: update MAINTAINERS for idef-parser, Anton Johansson, 2021/12/17
- [PATCH v7 12/13] target/hexagon: import additional tests, Anton Johansson, 2021/12/17