[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 9/9] tests/qtest/virtio-net-failover: Use g_file_open_tmp() to cre
From: |
Thomas Huth |
Subject: |
[PULL 9/9] tests/qtest/virtio-net-failover: Use g_file_open_tmp() to create temporary file |
Date: |
Wed, 22 Dec 2021 12:32:59 +0100 |
g_test_rand_int() must not be called before g_test_init(), otherwise
the glib will show a "g_rand_int: assertion 'rand != NULL' failed"
message in the log. So we could change the order here, but actually,
it's safer to use g_file_open_tmp() anyway, so let's use that function
now instead.
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20211222083652.776592-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/virtio-net-failover.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/virtio-net-failover.c
b/tests/qtest/virtio-net-failover.c
index 4b2ba8a106..22ad54bb95 100644
--- a/tests/qtest/virtio-net-failover.c
+++ b/tests/qtest/virtio-net-failover.c
@@ -1306,13 +1306,15 @@ static void test_multi_in(gconstpointer opaque)
int main(int argc, char **argv)
{
- const gchar *tmpdir = g_get_tmp_dir();
- gchar *tmpfile = g_strdup_printf("%s/failover_test_migrate-%u-%u",
- tmpdir, getpid(), g_test_rand_int());
+ gchar *tmpfile;
int ret;
g_test_init(&argc, &argv, NULL);
+ ret = g_file_open_tmp("failover_test_migrate-XXXXXX", &tmpfile, NULL);
+ g_assert_true(ret >= 0);
+ close(ret);
+
qtest_add_func("failover-virtio-net/params/error/id", test_error_id);
qtest_add_func("failover-virtio-net/params/error/pcie", test_error_pcie);
qtest_add_func("failover-virtio-net/params/on", test_on);
--
2.27.0
- [PULL 0/9] qtest fixes and improvements, Thomas Huth, 2021/12/22
- [PULL 1/9] failover: Silence warning messages during qtest, Thomas Huth, 2021/12/22
- [PULL 2/9] tests/qtest/boot-serial-test: Silence the warning about deprecated sga device, Thomas Huth, 2021/12/22
- [PULL 3/9] tests/qtest: Make the filter tests independent from a specific NIC, Thomas Huth, 2021/12/22
- [PULL 5/9] tests/qtest: Add a function that checks whether a device is available, Thomas Huth, 2021/12/22
- [PULL 6/9] tests/qtest: Improve endianness-test to work with missing machines and devices, Thomas Huth, 2021/12/22
- [PULL 4/9] MAINTAINERS: Update COLO Proxy section, Thomas Huth, 2021/12/22
- [PULL 9/9] tests/qtest/virtio-net-failover: Use g_file_open_tmp() to create temporary file,
Thomas Huth <=
- [PULL 8/9] tests/qtest/boot-order-test: Check whether machines are available, Thomas Huth, 2021/12/22
- [PULL 7/9] tests/qtest/cdrom-test: Check whether devices are available before using them, Thomas Huth, 2021/12/22
- Re: [PULL 0/9] qtest fixes and improvements, Richard Henderson, 2021/12/22