|
From: | Richard Henderson |
Subject: | Re: [PATCH 2/3] user: move common-user includes to a subdirectory of {bsd,linux}-user/ |
Date: | Tue, 21 Dec 2021 11:56:04 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 |
On 12/21/21 8:32 AM, Paolo Bonzini wrote:
Avoid polluting the compilation of common-user/ with local include files; making an include file available to common-user/ should be a deliberate decision in order to keep a clear interface that can be used by both bsd-user/ and linux-user/.
The reason that I did not do this before is that very shortly we're going to have bsd-user/host/arch/host-signal.h too.
If we combine them into a top-level include like this, then we have to add host-specific ifdefs. IMO it is cleaner to leave them separate.
If you really really want to move them out of <os>-user/include/host, then the only other thing I can suggest is include/host/<os>/<arch>/.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |