RE: [PATCH] tests/qtest: Make the filter tests independent from a specific NIC

[Zhang, Chen]

> -----Original Message-----
> From: Thomas Huth <thuth@redhat.com>
> Sent: Tuesday, December 21, 2021 3:35 PM
> To: Zhang, Chen <chen.zhang@intel.com>; qemu-devel@nongnu.org;
> Laurent Vivier <lvivier@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Subject: Re: [PATCH] tests/qtest: Make the filter tests independent from a
> specific NIC
> 
> On 21/12/2021 07.38, Zhang, Chen wrote:
> >
> >
> >> -----Original Message-----
> >> From: Qemu-devel <qemu-devel-
> >> bounces+chen.zhang=intel.com@nongnu.org> On Behalf Of Thomas
> Huth
> >> Sent: Monday, December 20, 2021 6:30 PM
> >> To: qemu-devel@nongnu.org; Laurent Vivier <lvivier@redhat.com>
> >> Cc: Paolo Bonzini <pbonzini@redhat.com>; Yang Hongyang
> >> <yanghy@cn.fujitsu.com>; Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
> >> Subject: [PATCH] tests/qtest: Make the filter tests independent from
> >> a specific NIC
> >>
> >> These filter tests need a NIC, no matter which one, so they use a
> >> common NIC by default. However, these common NIC models might not
> >> always have been compiled into the QEMU target binary, so assuming
> >> that a certain NIC is available is a bad idea. Since the exact type
> >> of NIC does not really matter for these tests, let's switch to "-nic"
> >> instead of "-netdev" so that QEMU can simply pick a default NIC for us.
> >> This way we can now run the tests on other targets that have a
> >> default machine with an on-board/default NIC, too.
> >>
> >
> > Oh, It's my and Hongyang's abandoned mailbox.
> 
> Sorry, I only looked at the top of the *.c files and copied the e-mail address
> from there.
> 
> > Looks good to me.
> 
> Thanks for the review!
> 
> > By the way, should I add the test/qtest/test-filter* to the MAINTAINER file?
> 
> That might be helpful indeed to get you CC:-ed correctly next time.

Already send a patch to update it.

Thanks
Chen

> 
>   Thomas