[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 14/16] hw/scsi/megasas: Fails command if SGL buffer overflows
From: |
Paolo Bonzini |
Subject: |
[PULL 14/16] hw/scsi/megasas: Fails command if SGL buffer overflows |
Date: |
Sun, 19 Dec 2021 15:20:06 +0100 |
From: Philippe Mathieu-Daudé <philmd@redhat.com>
If we detect an overflow on the SGL buffer, do not
keep processing the command: discard it. TARGET_FAILURE
sense code will be returned (MFI_STAT_SCSI_DONE_WITH_ERROR).
Reported-by: Alexander Bulekov <alxndr@bu.edu>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/521
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Message-Id: <20211119201141.532377-2-philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/megasas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index 4ff51221d4..8f35784100 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -303,6 +303,7 @@ static int megasas_map_sgl(MegasasState *s, MegasasCmd
*cmd, union mfi_sgl *sgl)
}
if (cmd->iov_size > iov_size) {
trace_megasas_iovec_overflow(cmd->index, iov_size, cmd->iov_size);
+ goto unmap;
} else if (cmd->iov_size < iov_size) {
trace_megasas_iovec_underflow(cmd->index, iov_size, cmd->iov_size);
}
--
2.33.1
- [PULL 05/16] configure: unify x86_64 and x32, (continued)
- [PULL 05/16] configure: unify x86_64 and x32, Paolo Bonzini, 2021/12/19
- [PULL 06/16] meson: rename "arch" variable, Paolo Bonzini, 2021/12/19
- [PULL 07/16] configure, meson: move ARCH to meson.build, Paolo Bonzini, 2021/12/19
- [PULL 08/16] configure: remove unnecessary symlinks, Paolo Bonzini, 2021/12/19
- [PULL 10/16] meson: reenable test-fdmon-epoll, Paolo Bonzini, 2021/12/19
- [PULL 11/16] cpu: remove unnecessary #ifdef CONFIG_TCG, Paolo Bonzini, 2021/12/19
- [PULL 09/16] configure: remove DIRS, Paolo Bonzini, 2021/12/19
- [PULL 12/16] meson: add "check" argument to run_command, Paolo Bonzini, 2021/12/19
- [PULL 13/16] hw/scsi: Fix scsi_bus_init_named() docstring, Paolo Bonzini, 2021/12/19
- [PULL 14/16] hw/scsi/megasas: Fails command if SGL buffer overflows,
Paolo Bonzini <=
- [PULL 15/16] tests/qtest/fuzz-megasas-test: Add test for GitLab issue #521, Paolo Bonzini, 2021/12/19
- [PULL 16/16] hw/i386/vmmouse: Require 'i8042' property to be set, Paolo Bonzini, 2021/12/19
- Re: [PULL 00/16] Misc patches for 2021-12-20, Richard Henderson, 2021/12/19