[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 25/25] python: rename qemu.aqmp to qemu.qmp
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH v2 25/25] python: rename qemu.aqmp to qemu.qmp |
Date: |
Thu, 16 Dec 2021 14:41:36 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
15.12.2021 22:39, John Snow wrote:
Now that we are fully switched over to the new QMP library, move it back
over the old namespace. This is being done primarily so that we may
upload this package simply as "qemu.qmp" without introducing confusion
over whether or not "aqmp" is a new protocol or not.
The trade-off is increased confusion inside the QEMU developer
tree. Sorry!
Signed-off-by: John Snow<jsnow@redhat.com>
Great job!
I looked thorough the patch, changes looks correct. Simply rename every aqmp /
AQMP occurrence.. But:
[root@kvm review]# git grep -i aqmp
python/qemu/qmp/aqmp_tui.py:AQMP TUI
python/qemu/qmp/aqmp_tui.py:AQMP TUI is an asynchronous interface built on top
the of the AQMP library.
python/qemu/qmp/aqmp_tui.py:Example Usage: aqmp-tui <SOCKET | TCP IP:PORT>
python/qemu/qmp/aqmp_tui.py:Full Usage: aqmp-tui --help
python/qemu/qmp/aqmp_tui.py: Implements the AQMP TUI.
python/qemu/qmp/aqmp_tui.py: parser =
argparse.ArgumentParser(description='AQMP TUI')
python/qemu/qmp/legacy.py: self._aqmp = QMPClient(nickname)
python/qemu/qmp/legacy.py: if self._aqmp.greeting is not None:
python/qemu/qmp/legacy.py: return self._aqmp.greeting._asdict()
python/qemu/qmp/legacy.py: self._aqmp.await_greeting = negotiate
python/qemu/qmp/legacy.py: self._aqmp.negotiate = negotiate
python/qemu/qmp/legacy.py: self._aqmp.connect(self._address)
python/qemu/qmp/legacy.py: self._aqmp.await_greeting = True
python/qemu/qmp/legacy.py: self._aqmp.negotiate = True
python/qemu/qmp/legacy.py: self._aqmp.accept(self._address),
python/qemu/qmp/legacy.py: self._aqmp._raw(qmp_cmd,
assign_id=False),
python/qemu/qmp/legacy.py: self._aqmp.execute(cmd, kwds),
python/qemu/qmp/legacy.py: if self._aqmp.events.empty():
python/qemu/qmp/legacy.py: self._aqmp.events.get(),
python/qemu/qmp/legacy.py: events = [dict(x) for x in
self._aqmp.events.clear()]
python/qemu/qmp/legacy.py: self._aqmp.events.clear()
python/qemu/qmp/legacy.py: self._aqmp.disconnect()
python/qemu/qmp/legacy.py: self._aqmp.send_fd_scm(fd)
python/qemu/qmp/legacy.py: if self._aqmp.runstate == Runstate.IDLE:
python/setup.cfg:# AQMP TUI dependencies
python/setup.cfg: aqmp-tui = qemu.qmp.aqmp_tui:main [tui]
python/setup.cfg:[mypy-qemu.qmp.aqmp_tui]
[root@kvm review]# git ls-tree -r --name-only HEAD | grep -i aqmp
python/qemu/qmp/aqmp_tui.py
I think, this all should be renamed too
--
Best regards,
Vladimir
- Re: [PATCH v2 17/25] iotests/mirror-top-perms: switch to AQMP, (continued)
[PATCH v2 24/25] python: re-enable pylint duplicate-code warnings, John Snow, 2021/12/15
[PATCH v2 23/25] python: remove the old QMP package, John Snow, 2021/12/15
[PATCH v2 22/25] python/aqmp: copy qmp docstrings to qemu.aqmp.legacy, John Snow, 2021/12/15