[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] gqa-win: get_pci_info: Clean dev_info if handle is valid
From: |
Marc-André Lureau |
Subject: |
Re: [PATCH 1/5] gqa-win: get_pci_info: Clean dev_info if handle is valid |
Date: |
Mon, 13 Dec 2021 23:37:50 +0400 |
On Mon, Dec 13, 2021 at 3:16 PM Kostiantyn Kostiuk
<konstantin@daynix.com> wrote:
>
> Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
> Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qga/commands-win32.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 4e84afd83b..3dd74fe225 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -514,7 +514,7 @@ DEFINE_GUID(GUID_DEVINTERFACE_STORAGEPORT,
>
> static GuestPCIAddress *get_pci_info(int number, Error **errp)
> {
> - HDEVINFO dev_info;
> + HDEVINFO dev_info = INVALID_HANDLE_VALUE;
> SP_DEVINFO_DATA dev_info_data;
> SP_DEVICE_INTERFACE_DATA dev_iface_data;
> HANDLE dev_file;
> @@ -749,7 +749,9 @@ static GuestPCIAddress *get_pci_info(int number, Error
> **errp)
> }
>
> free_dev_info:
> - SetupDiDestroyDeviceInfoList(dev_info);
> + if (dev_info != INVALID_HANDLE_VALUE) {
> + SetupDiDestroyDeviceInfoList(dev_info);
> + }
> out:
> return pci;
> }
> --
> 2.25.1
>
- [PATCH 0/5] gqa-win: get_pci_info: Fix memory leak, Kostiantyn Kostiuk, 2021/12/13
- [PATCH 3/5] gqa-win: get_pci_info: Free parent_dev_info properly, Kostiantyn Kostiuk, 2021/12/13
- [PATCH 4/5] gqa-win: get_pci_info: Replace 'while' with 2 calls of the function, Kostiantyn Kostiuk, 2021/12/13
- [PATCH 1/5] gqa-win: get_pci_info: Clean dev_info if handle is valid, Kostiantyn Kostiuk, 2021/12/13
- Re: [PATCH 1/5] gqa-win: get_pci_info: Clean dev_info if handle is valid,
Marc-André Lureau <=
- [PATCH 5/5] gqa-win: get_pci_info: Add g_autofree for few variables, Kostiantyn Kostiuk, 2021/12/13
- [PATCH 2/5] gqa-win: get_pci_info: Use common 'cleanup' label, Kostiantyn Kostiuk, 2021/12/13