[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/4] include/sysemu/blockdev.h: move drive_add and inline
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v2 3/4] include/sysemu/blockdev.h: move drive_add and inline drive_def |
Date: |
Mon, 13 Dec 2021 15:41:30 +0000 |
On Tue, Nov 30, 2021 at 04:46:32AM -0500, Emanuele Giuseppe Esposito wrote:
> drive_add is only used in softmmu/vl.c, so it can be a static
> function there, and drive_def is only a particular use case of
> qemu_opts_parse_noisily, so it can be inlined.
>
> Also remove drive_mark_claimed_by_board, as it is only defined
> but not implemented (nor used) anywhere.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> block/monitor/block-hmp-cmds.c | 2 +-
> blockdev.c | 25 -------------------------
> include/sysemu/blockdev.h | 4 ----
> softmmu/vl.c | 25 ++++++++++++++++++++++++-
> 4 files changed, 25 insertions(+), 31 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH v2 3/4] include/sysemu/blockdev.h: move drive_add and inline drive_def,
Stefan Hajnoczi <=