[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 5/7] For qemu_io* functions support --image-opts argument, whi
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v4 5/7] For qemu_io* functions support --image-opts argument, which conflicts with -f argument from qemu_io_args. |
Date: |
Mon, 13 Dec 2021 16:32:38 +0100 |
For QemuIoInteractive use new wrapper as well, which allows relying on
default format.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/iotests.py | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 7f9a8bf012..1ed3eb1058 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -240,10 +240,15 @@ def img_info_log(filename, filter_path=None,
imgopts=False, extra_args=()):
filter_path = filename
log(filter_img_info(output, filter_path))
+def qemu_io_wrap_args(args: Sequence[str]) -> List[str]:
+ if '-f' in args or '--image-opts' in args:
+ return qemu_io_args_no_fmt + list(args)
+ else:
+ return qemu_io_args + list(args)
+
def qemu_io(*args):
'''Run qemu-io and return the stdout data'''
- args = qemu_io_args + list(args)
- return qemu_tool_pipe_and_status('qemu-io', args)[0]
+ return qemu_tool_pipe_and_status('qemu-io', qemu_io_wrap_args(args))[0]
def qemu_io_log(*args):
result = qemu_io(*args)
@@ -252,12 +257,7 @@ def qemu_io_log(*args):
def qemu_io_silent(*args):
'''Run qemu-io and return the exit code, suppressing stdout'''
- if '-f' in args or '--image-opts' in args:
- default_args = qemu_io_args_no_fmt
- else:
- default_args = qemu_io_args
-
- args = default_args + list(args)
+ args = qemu_io_wrap_args(args)
result = subprocess.run(args, stdout=subprocess.DEVNULL, check=False)
if result.returncode < 0:
sys.stderr.write('qemu-io received signal %i: %s\n' %
@@ -266,14 +266,14 @@ def qemu_io_silent(*args):
def qemu_io_silent_check(*args):
'''Run qemu-io and return the true if subprocess returned 0'''
- args = qemu_io_args + list(args)
+ args = qemu_io_wrap_args(args)
result = subprocess.run(args, stdout=subprocess.DEVNULL,
stderr=subprocess.STDOUT, check=False)
return result.returncode == 0
class QemuIoInteractive:
def __init__(self, *args):
- self.args = qemu_io_args_no_fmt + list(args)
+ self.args = qemu_io_wrap_args(args)
# We need to keep the Popen objext around, and not
# close it immediately. Therefore, disable the pylint check:
# pylint: disable=consider-using-with
--
2.31.1
- [PATCH v4 0/7] nbd reconnect on open, Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 4/7] iotests.py: add qemu_tool_popen(), Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 1/7] nbd: allow reconnect on open, with corresponding new options, Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 5/7] For qemu_io* functions support --image-opts argument, which conflicts with -f argument from qemu_io_args.,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v4 2/7] nbd/client-connection: nbd_co_establish_connection(): return real error, Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 6/7] Add qemu-io Popen constructor wrapper. To be used in the following new test commit., Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 3/7] nbd/client-connection: improve error message of cancelled attempt, Vladimir Sementsov-Ogievskiy, 2021/12/13
- [PATCH v4 7/7] iotests: add nbd-reconnect-on-open test, Vladimir Sementsov-Ogievskiy, 2021/12/13
- Re: [PATCH v4 0/7] nbd reconnect on open, Vladimir Sementsov-Ogievskiy, 2021/12/21