|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 06/26] hw/intc/arm_gicv3_its: Reduce code duplication in extract_table_params() |
Date: | Sun, 12 Dec 2021 21:47:51 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 12/11/21 20:11, Peter Maydell wrote: > The extract_table_params() decodes the fields in the GITS_BASER<n> > registers into TableDesc structs. Since the fields are the same for > all the GITS_BASER<n> registers, there is currently a lot of code > duplication within the switch (type) statement. Refactor so that the > cases include only what is genuinely different for each type: > the calculation of the number of bits in the ID value that indexes > into the table. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/intc/arm_gicv3_its.c | 97 +++++++++++++++++------------------------ > 1 file changed, 40 insertions(+), 57 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
[Prev in Thread] | Current Thread | [Next in Thread] |