[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/8] virtio_video: Add Fast Walsh-Hadamard Transform format
From: |
Peter Griffin |
Subject: |
Re: [PATCH 6/8] virtio_video: Add Fast Walsh-Hadamard Transform format |
Date: |
Fri, 10 Dec 2021 12:45:27 +0000 |
Hi Michael,
On Fri, 10 Dec 2021, Michael S. Tsirkin wrote:
> On Thu, Dec 09, 2021 at 02:55:59PM +0000, Peter Griffin wrote:
> > Linux vicodec (Virtual Codec) test driver in Linux implements
> > FWHT. FWHT was designed to be fast and simple and to have
> > characteristics of other video codecs and therefore face similar
> > issues [1].
> >
> > https://en.wikipedia.org/wiki/Fast_Walsh%E2%80%93Hadamard_transform
> >
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> > include/standard-headers/linux/virtio_video.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/standard-headers/linux/virtio_video.h
> > b/include/standard-headers/linux/virtio_video.h
> > index 16b5f642a9..3b517d50c4 100644
> > --- a/include/standard-headers/linux/virtio_video.h
> > +++ b/include/standard-headers/linux/virtio_video.h
> > @@ -75,6 +75,7 @@ enum virtio_video_format {
> > VIRTIO_VIDEO_FORMAT_HEVC, /* HEVC aka H.265*/
> > VIRTIO_VIDEO_FORMAT_VP8, /* VP8 */
> > VIRTIO_VIDEO_FORMAT_VP9, /* VP9 */
> > + VIRTIO_VIDEO_FORMAT_FWHT, /* FWHT used by vicodec */
> > VIRTIO_VIDEO_FORMAT_CODED_MAX = VIRTIO_VIDEO_FORMAT_VP9,
>
> Is last line still correct? Seems fragile ...
Ah good spot! This is a typo, I should have updated it to
VIRTIO_VIDEO_FORMAT_CODED_MAX = VIRTIO_VIDEO_FORMAT_FWHT,
Will fix in the next iteration.
Peter.
- [PATCH 5/8] standard-headers: Add virtio_video.h, (continued)
- [PATCH 3/8] vhost-user-video: boiler plate code for vhost-user-video device, Peter Griffin, 2021/12/09
- [PATCH 6/8] virtio_video: Add Fast Walsh-Hadamard Transform format, Peter Griffin, 2021/12/09
- [PATCH 7/8] hw/display: add vhost-user-video-pci, Peter Griffin, 2021/12/09
- [PATCH 4/8] vhost-user-video: add meson subdir build logic, Peter Griffin, 2021/12/09
- [PATCH 8/8] tools/vhost-user-video: Add initial vhost-user-video vmm, Peter Griffin, 2021/12/09