[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 00/10] PMU-EBB support for PPC64 TCG
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH v9 00/10] PMU-EBB support for PPC64 TCG |
Date: |
Fri, 3 Dec 2021 10:37:39 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
Hello,
On 12/1/21 16:17, Daniel Henrique Barboza wrote:
Hi,
In this new version the most significant change is in patch 6,
where a new hflag allows us to not call the instruction helper
inside translate.c unless we're absolutely certain that there
is an instruction count event being sampled and active in the
PMU. This change turned out to be a big boost in performance
in the PMU emulation overall, most notably when dealing with
cycle events that were calling the helper needlessly.
This and all other changes were suggested by David in his review
of the previous version.
patch 1-8 look good. I still have some questions on the exception
handling and how EBB are gated.
I am asking to get the model right for the next step which should
be to modify the XIVE interrupt controller to generate External
EBB exceptions.
One more comment, not for now, since the EBB patchset is nearly
ready.
May be, it is time to think about introducing a per-CPU model
excp_handlers[] array indexed by POWERPC_EXCP_* exception
numbers and to duplicate some code for the sake of clarity.
Fabiano, isn't it what you had in mind ?
Thanks,
C.
- [PATCH v9 06/10] target/ppc: enable PMU instruction count, (continued)
- [PATCH v9 06/10] target/ppc: enable PMU instruction count, Daniel Henrique Barboza, 2021/12/01
- [PATCH v9 07/10] target/ppc/power8-pmu.c: add PM_RUN_INST_CMPL (0xFA) event, Daniel Henrique Barboza, 2021/12/01
- [PATCH v9 08/10] PPC64/TCG: Implement 'rfebb' instruction, Daniel Henrique Barboza, 2021/12/01
- [PATCH v9 09/10] target/ppc: PMU Event-Based exception support, Daniel Henrique Barboza, 2021/12/01
- [PATCH v9 10/10] target/ppc/excp_helper.c: EBB handling adjustments, Daniel Henrique Barboza, 2021/12/01
- Re: [PATCH v9 00/10] PMU-EBB support for PPC64 TCG,
Cédric Le Goater <=
- Re: [PATCH v9 00/10] PMU-EBB support for PPC64 TCG, Cédric Le Goater, 2021/12/15