[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/20] NBD patches through 2021-09-27
From: |
Daniel P . Berrangé |
Subject: |
Re: [PULL 00/20] NBD patches through 2021-09-27 |
Date: |
Thu, 30 Sep 2021 09:29:40 +0100 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Wed, Sep 29, 2021 at 01:29:21PM -0500, Eric Blake wrote:
> On Wed, Sep 29, 2021 at 05:03:08PM +0200, Paolo Bonzini wrote:
> > On 29/09/21 15:58, Richard Henderson wrote:
> > >
> > > > /usr/bin/ld: /usr/lib64/libselinux.so: error adding symbols: file
> > > in
> > > > wrong format
> > > > collect2: error: ld returned 1 exit status
> > >
> > > Missing libselinux-devel.i686 in
> > > tests/docker/dockerfiles/fedora-i386-cross.docker, I think?
> > >
> > > But additionally, incorrect package probing, I think.
> >
> > Probably Meson deciding to look at --print-search-dirs and crossing fingers.
> > But -m32 and other multilib flags should be added to config-meson.cross
> > rather than QEMU_CFLAGS.
>
> Rich, Dan, this is caused by 'nbd/server: Add --selinux-label option'
> (20/20 in this pull request); can you investigate?
I think this is a bug in the fedora-i386-cross.docker file
It sets
ENV PKG_CONFIG_PATH /usr/lib/pkgconfig
which *adds* /usr/lib/pkgconfig to the pkg-config search path, in
additional to all existing search paths. IOW, it'll look in this
32-bit directory, and then carry on looking in all the 64-bit
directories.
For cross compiling it is neccessary to set PKG_CONFIG_LIBDIR
instead, which completely replaces the default paths.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PULL 14/20] nbd/client-connection: nbd_co_establish_connection(): fix non set errp, (continued)
- [PULL 14/20] nbd/client-connection: nbd_co_establish_connection(): fix non set errp, Eric Blake, 2021/09/27
- [PULL 16/20] block/nbd: move nbd_recv_coroutines_wake_all() up, Eric Blake, 2021/09/27
- [PULL 19/20] block/nbd: check that received handle is valid, Eric Blake, 2021/09/27
- [PULL 20/20] nbd/server: Add --selinux-label option, Eric Blake, 2021/09/27
- Re: [PULL 00/20] NBD patches through 2021-09-27, Peter Maydell, 2021/09/29
- Re: [PULL 00/20] NBD patches through 2021-09-27, Paolo Bonzini, 2021/09/29
- Re: [PULL 00/20] NBD patches through 2021-09-27, Richard Henderson, 2021/09/29
- Re: [PULL 00/20] NBD patches through 2021-09-27, Paolo Bonzini, 2021/09/29
- Re: [PULL 00/20] NBD patches through 2021-09-27, Eric Blake, 2021/09/29
- Re: [PULL 00/20] NBD patches through 2021-09-27, Richard W.M. Jones, 2021/09/29
- Re: [PULL 00/20] NBD patches through 2021-09-27,
Daniel P . Berrangé <=
- Re: [PULL 00/20] NBD patches through 2021-09-27, Richard W.M. Jones, 2021/09/30
- Re: [PULL 00/20] NBD patches through 2021-09-27, Richard Henderson, 2021/09/30
- Re: [PULL 00/20] NBD patches through 2021-09-27, Richard W.M. Jones, 2021/09/30