Re: [PATCH v3 17/27] linux-user/nios2: Map a real kuser page

[Richard Henderson]

On 9/27/21 9:26 AM, Peter Maydell wrote:
> > +    /*
> > +     * If the mmap doesn't give us exactly page 1, there's nothing
> > +     * we can do, and it's unlikely that the program will be able
> > +     * to continue.  FIXME: Error out now?
> > +     */
> > +    assert(pg == TARGET_PAGE_SIZE);
>
> Shouldn't we be doing this via the probe_guest_base machinery
> the way we do for the Arm commpage ?

Well, maybe.  Though the Arm commpage continues to not work.

https://gitlab.com/qemu-project/qemu/-/issues/633
https://gitlab.com/qemu-project/qemu/-/issues/447

But you're right, this could just as easily error out on a 32-bit host.


r~