qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 17/27] linux-user/nios2: Map a real kuser page


From: Richard Henderson
Subject: Re: [PATCH v3 17/27] linux-user/nios2: Map a real kuser page
Date: Mon, 27 Sep 2021 09:59:39 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 9/27/21 9:26 AM, Peter Maydell wrote:
+    /*
+     * If the mmap doesn't give us exactly page 1, there's nothing
+     * we can do, and it's unlikely that the program will be able
+     * to continue.  FIXME: Error out now?
+     */
+    assert(pg == TARGET_PAGE_SIZE);

Shouldn't we be doing this via the probe_guest_base machinery
the way we do for the Arm commpage ?

Well, maybe.  Though the Arm commpage continues to not work.

https://gitlab.com/qemu-project/qemu/-/issues/633
https://gitlab.com/qemu-project/qemu/-/issues/447

But you're right, this could just as easily error out on a 32-bit host.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]