[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 14/27] linux-user/mips: Tidy install_sigtramp
From: |
Richard Henderson |
Subject: |
[PATCH v3 14/27] linux-user/mips: Tidy install_sigtramp |
Date: |
Fri, 24 Sep 2021 12:59:13 -0400 |
The return value is constant 0, and unused as well -- change to void.
Drop inline marker. Change tramp type to uint32_t* for clarity.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/mips/signal.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/linux-user/mips/signal.c b/linux-user/mips/signal.c
index d174b3453c..64072779b9 100644
--- a/linux-user/mips/signal.c
+++ b/linux-user/mips/signal.c
@@ -87,10 +87,8 @@ struct target_rt_sigframe {
};
/* Install trampoline to jump back from signal handler */
-static inline int install_sigtramp(unsigned int *tramp, unsigned int syscall)
+static void install_sigtramp(uint32_t *tramp, unsigned int syscall)
{
- int err = 0;
-
/*
* Set up the return code ...
*
@@ -100,7 +98,6 @@ static inline int install_sigtramp(unsigned int *tramp,
unsigned int syscall)
__put_user(0x24020000 + syscall, tramp + 0);
__put_user(0x0000000c , tramp + 1);
- return err;
}
static inline void setup_sigcontext(CPUMIPSState *regs,
--
2.25.1
- RE: [PATCH v3 08/27] linux-user/hexagon: Implement setup_sigtramp, (continued)
- [PATCH v3 11/27] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set, Richard Henderson, 2021/09/24
- [PATCH v3 09/27] linux-user/hppa: Document non-use of setup_sigtramp, Richard Henderson, 2021/09/24
- [PATCH v3 10/27] linux-user/i386: Implement setup_sigtramp, Richard Henderson, 2021/09/24
- [PATCH v3 16/27] linux-user/nios2: Properly emulate EXCP_TRAP, Richard Henderson, 2021/09/24
- [PATCH v3 15/27] linux-user/mips: Implement setup_sigtramp, Richard Henderson, 2021/09/24
- [PATCH v3 12/27] linux-user/m68k: Implement setup_sigtramp, Richard Henderson, 2021/09/24
- [PATCH v3 14/27] linux-user/mips: Tidy install_sigtramp,
Richard Henderson <=
- [PATCH v3 18/27] linux-user/nios2: Fixes for signal frame setup, Richard Henderson, 2021/09/24
- [PATCH v3 20/27] linux-user/ppc: Simplify encode_trampoline, Richard Henderson, 2021/09/24
- [PATCH v3 19/27] linux-user/openrisc: Implement setup_sigtramp, Richard Henderson, 2021/09/24
- [PATCH v3 21/27] linux-user/ppc: Implement setup_sigtramp, Richard Henderson, 2021/09/24
- [PATCH v3 27/27] linux-user: Remove default for TARGET_ARCH_HAS_SIGTRAMP_PAGE, Richard Henderson, 2021/09/24
- [PATCH v3 23/27] linux-user/s390x: Implement setup_sigtramp, Richard Henderson, 2021/09/24
- [PATCH v3 22/27] linux-user/riscv: Implement setup_sigtramp, Richard Henderson, 2021/09/24