[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] docs/nvdimm: Update nvdimm option value in machine exampl
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2] docs/nvdimm: Update nvdimm option value in machine example |
Date: |
Thu, 23 Sep 2021 16:59:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
Le 23/09/2021 à 12:30, Pankaj Gupta a écrit :
> Update nvdimm option value in example command from "-machine pc,nvdimm"
> to "-machine pc,nvdimm=on" as former complains with the below error:
>
> "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter
> 'nvdimm'"
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
> ---
> docs/nvdimm.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
> index 0aae682be3..fd7773dc5a 100644
> --- a/docs/nvdimm.txt
> +++ b/docs/nvdimm.txt
> @@ -15,7 +15,7 @@ backend (i.e. memory-backend-file and memory-backend-ram).
> A simple
> way to create a vNVDIMM device at startup time is done via the
> following command line options:
>
> - -machine pc,nvdimm
> + -machine pc,nvdimm=on
> -m $RAM_SIZE,slots=$N,maxmem=$MAX_SIZE
> -object
> memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE,readonly=off
> -device nvdimm,id=nvdimm1,memdev=mem1,unarmed=off
>
Applied to my trivial-patches branch.
Thanks,
Laurent