[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: qtest: bios-tables-test depends on the unpacked edk2
From: |
Peter Maydell |
Subject: |
Re: [PATCH] tests: qtest: bios-tables-test depends on the unpacked edk2 ROMs |
Date: |
Thu, 23 Sep 2021 11:44:20 +0100 |
On Thu, 23 Sept 2021 at 11:32, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 23/09/21 12:00, Philippe Mathieu-Daudé wrote:
> > See also "blobs: Only install required (system emulation) files":
> > https://lore.kernel.org/qemu-devel/20210323155132.238193-1-f4bug@amsat.org/
>
> Nice and makes a lot of sense. Regarding "there is probably a nicer way
> to do this with Meson", I would do without all the variables and do
> something like
>
> foreach target : target_dirs
> if target in ['...']
> blobs_ss.add('...')
> elif target in ['...']
> blobs_ss.add('...')
> endif
> endforeach
>
> directly in pc-bios/meson.build.
Is it possible also to have meson handle the "symlink the blob from
the source dir to the build dir" which currently configure is doing ?
That would mean we could avoid having effectively two lists of blobs.
(Somebody would need to cross-check that all the blobs the wildcards in
configure are linking in are listed in the meson list.) I guess
the question is whether other parts of the build system assume those
links already exist (ie they don't explicitly declare a dependency
on the existence of the blob and would need to change to do so).
thanks
-- PMM