Re: [PATCH v4 09/20] macfb: don't register declaration ROM

[Laurent Vivier]

Le 17/09/2021 à 09:50, Mark Cave-Ayland a écrit :
> The macfb device is an on-board framebuffer and so is initialised by the
> system declaration ROM included within the MacOS toolbox ROM.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  hw/display/macfb.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/hw/display/macfb.c b/hw/display/macfb.c
> index d8183b9bbd..76808b69cc 100644
> --- a/hw/display/macfb.c
> +++ b/hw/display/macfb.c
> @@ -383,10 +383,6 @@ static void macfb_sysbus_realize(DeviceState *dev, Error 
> **errp)
>      sysbus_init_mmio(SYS_BUS_DEVICE(s), &ms->mem_vram);
>  }
>  
> -const uint8_t macfb_rom[] = {
> -    255, 0, 0, 0,
> -};
> -
>  static void macfb_nubus_realize(DeviceState *dev, Error **errp)
>  {
>      NubusDevice *nd = NUBUS_DEVICE(dev);
> @@ -399,8 +395,6 @@ static void macfb_nubus_realize(DeviceState *dev, Error 
> **errp)
>      macfb_common_realize(dev, ms, errp);
>      memory_region_add_subregion(&nd->slot_mem, DAFB_BASE, &ms->mem_ctrl);
>      memory_region_add_subregion(&nd->slot_mem, VIDEO_BASE, &ms->mem_vram);
> -
> -    nubus_register_rom(nd, macfb_rom, sizeof(macfb_rom), 1, 9, 0xf);
>  }
>  
>  static void macfb_sysbus_reset(DeviceState *d)
> 

Will macfb continue to work with "-kernel" and without providing any MacOS ROM?

Thanks,
Laurent