[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type |
Date: |
Thu, 16 Sep 2021 15:53:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 9/16/21 2:29 PM, Cédric Le Goater wrote:
> On 9/14/21 17:22, Richard Henderson wrote:
>> On 9/14/21 5:26 AM, Peter Maydell wrote:
>>> (2) RAM blocks should have a length that fits inside a
>>> signed 32-bit type on 32-bit hosts (at least I assume this
>>> is where the 2047MB limit is coming from; in theory this ought
>>> to be improveable but auditing the code for mishandling of
>>> RAMblock sizes to ensure we weren't accidentally stuffing
>>> their size into a signed 'long' somewhere would be kind
>>> of painful)
>>> Even if we did fix (2) we'd need to compromise on (3)
>>> sometimes still -- if a board has 4GB of RAM that's
>>> not going to fit in 32 bits regardless. But we would be
>>> able to let boards with 2GB have 2GB.
>>
>> I'm not opposed to deprecating 32-bit hosts... ;-)
>
> Until then, I am willing to make the following compromise for the fuji :
>
> mc->default_ram_size = (HOST_LONG_BITS == 32 ? 1 : 2) * GiB;
While I disagree with this approach, better to document it clearly
like commit 25ff112a8cc ("hw/arm/mps2-tz: Add new mps3-an524 board").
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, (continued)
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Peter Delevoryas, 2021/09/14
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Joel Stanley, 2021/09/14
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Peter Maydell, 2021/09/14
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Richard Henderson, 2021/09/14
- Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Thomas Huth, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Philippe Mathieu-Daudé, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Daniel P . Berrangé, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Philippe Mathieu-Daudé, 2021/09/15
- Re: Deprecate 32-bit hosts? (was: Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type), Daniel P . Berrangé, 2021/09/15
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Cédric Le Goater, 2021/09/16
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type,
Philippe Mathieu-Daudé <=
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Cédric Le Goater, 2021/09/16
- Re: [PULL 14/14] hw/arm/aspeed: Add Fuji machine type, Peter Maydell, 2021/09/16
[PULL 05/14] hw: aspeed_gpio: Simplify 1.8V defines, Cédric Le Goater, 2021/09/13
[PULL 12/14] hw/arm/aspeed: Initialize AST2600 UART clock selection registers, Cédric Le Goater, 2021/09/13
[PULL 06/14] hw: aspeed_gpio: Clarify GPIO controller name, Cédric Le Goater, 2021/09/13
[PULL 09/14] aspeed: Emulate the AST2600A3, Cédric Le Goater, 2021/09/13
[PULL 13/14] hw/arm/aspeed: Allow machine to set UART default, Cédric Le Goater, 2021/09/13
[PULL 02/14] hw: arm: aspeed: Enable mac0/1 instead of mac1/2 for g220a, Cédric Le Goater, 2021/09/13
Re: [PULL 00/14] aspeed queue, Peter Maydell, 2021/09/14