[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 21/22] qapi: Drop simple unions
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 21/22] qapi: Drop simple unions |
Date: |
Tue, 14 Sep 2021 07:57:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Eric Blake <eblake@redhat.com> writes:
> On Mon, Sep 13, 2021 at 02:39:31PM +0200, Markus Armbruster wrote:
>> Simple unions predate flat unions. Having both complicates the QAPI
>> schema language and the QAPI generator. We haven't been using simple
>> unions in new code for a long time, because they are less flexible and
>> somewhat awkward on the wire.
>>
>> The previous commits eliminated simple union from the tree. Now drop
>> them from the QAPI schema language entirely, and update mentions of
>> "flat union" to just "union".
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> docs/devel/qapi-code-gen.rst | 125 ++++--------------
>> scripts/qapi/expr.py | 21 +--
>> scripts/qapi/schema.py | 101 +++-----------
>> .../qapi-schema/flat-union-array-branch.json | 2 +-
>> tests/qapi-schema/flat-union-empty.json | 2 +-
>> tests/qapi-schema/flat-union-int-branch.json | 2 +-
>> tests/qapi-schema/flat-union-no-base.err | 2 +-
>> tests/qapi-schema/flat-union-no-base.json | 2 +-
>> tests/qapi-schema/qapi-schema-test.json | 2 +-
>> tests/qapi-schema/reserved-member-u.json | 2 +-
>> tests/qapi-schema/union-base-empty.json | 2 +-
>> .../union-base-no-discriminator.err | 2 +-
>> .../union-base-no-discriminator.json | 2 +-
>> 13 files changed, 62 insertions(+), 205 deletions(-)
>
> Whee! What a fun ride!
3-2-1-gone! And good riddance :)
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thank you for your quick review!
- [PATCH 19/22] tests/qapi-schema: Drop simple union __org.qemu_x-Union1, (continued)
- [PATCH 19/22] tests/qapi-schema: Drop simple union __org.qemu_x-Union1, Markus Armbruster, 2021/09/13
- [PATCH 13/22] test-qobject-output-visitor: Wean off UserDefListUnion, Markus Armbruster, 2021/09/13
- [PATCH 08/22] qapi: Convert simple union SocketAddressLegacy to flat one, Markus Armbruster, 2021/09/13
- [PATCH 18/22] test-clone-visitor: Wean off __org.qemu_x-Union1, Markus Armbruster, 2021/09/13
- [PATCH 21/22] qapi: Drop simple unions, Markus Armbruster, 2021/09/13
- Re: [PATCH 00/22] qapi: Remove simple unions from the schema language, Markus Armbruster, 2021/09/13