[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/22] qapi: Tidy up unusual line breaks
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 01/22] qapi: Tidy up unusual line breaks |
Date: |
Mon, 13 Sep 2021 15:54:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> Hi
>
> On Mon, Sep 13, 2021 at 4:39 PM Markus Armbruster <armbru@redhat.com> wrote:
>
>> Break lines between members instead of within members.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> I wish we would just automated tools to format files. With that git 2.23
> feature, no more excuses :):
> https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame
Interesting.
> Sadly, our mixed json/py format doesn't get parsed after "blake" reformats
> it (strings or trailing commas).
Naming QAPI schema files .json even though their contents isn't was a
mistake.
We discussed possible improvements in the thread below
Message-ID: <87ime52wxd.fsf@dusky.pond.sub.org>
https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg08325.html
Too much to read, but there's a summary:
Message-ID: <877dt5ofoi.fsf@dusky.pond.sub.org>
https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg02553.html
The least invasive way to achieve formatting automation could be
switching from bastardized JSON to proper subset of Python.
What's "blake"?
- [PATCH 16/22] tests/qapi-schema: Simple union UserDefListUnion is now unused, drop, (continued)
- [PATCH 16/22] tests/qapi-schema: Simple union UserDefListUnion is now unused, drop, Markus Armbruster, 2021/09/13
- [PATCH 14/22] test-clone-visitor: Wean off UserDefListUnion, Markus Armbruster, 2021/09/13
- [PATCH 15/22] tests/qapi-schema: Wean off UserDefListUnion, Markus Armbruster, 2021/09/13
- [PATCH 22/22] test-clone-visitor: Correct an accidental rename, Markus Armbruster, 2021/09/13
- [PATCH 01/22] qapi: Tidy up unusual line breaks, Markus Armbruster, 2021/09/13
- [PATCH 20/22] tests/qapi-schema: Purge simple unions from tests, Markus Armbruster, 2021/09/13
- [PATCH 03/22] qapi: Convert simple union KeyValue to flat one, Markus Armbruster, 2021/09/13
- [PATCH 07/22] qapi: Convert simple union ChardevBackend to flat one, Markus Armbruster, 2021/09/13
- [PATCH 17/22] tests/qapi-schema: Rewrite simple union TestIfUnion to be flat, Markus Armbruster, 2021/09/13