[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] hmp: Unbreak "change vnc"
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 1/2] hmp: Unbreak "change vnc" |
Date: |
Thu, 9 Sep 2021 09:42:34 +0100 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Thu, Sep 09, 2021 at 10:12:18AM +0200, Markus Armbruster wrote:
> HMP command "change vnc" can take the password as argument, or prompt
> for it:
>
> (qemu) change vnc password 123
> (qemu) change vnc password
> Password: ***
> (qemu)
>
> This regressed in commit cfb5387a1d "hmp: remove "change vnc TARGET"
> command", v6.0.0.
>
> (qemu) change vnc passwd 123
> Password: ***
> (qemu) change vnc passwd
> (qemu)
>
> The latter passes NULL to qmp_change_vnc_password(), which is a no-no.
> Looks like it puts the display into "password required, but none set"
> state.
>
> The logic error is easy to miss in review, but testing should've
> caught it.
>
> Fix the obvious way.
>
> Fixes: cfb5387a1de2acda23fb5c97d2378b9e7ddf8025
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> monitor/hmp-cmds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 0/2] hmp: Unbreak "change vnc", tidy up set_password's doc, Markus Armbruster, 2021/09/09
- [PATCH 1/2] hmp: Unbreak "change vnc", Markus Armbruster, 2021/09/09
- [PATCH 2/2] hmp: Drop a bogus sentence from set_password's documentation, Markus Armbruster, 2021/09/09
- Re: [PATCH 0/2] hmp: Unbreak "change vnc", tidy up set_password's doc, Gerd Hoffmann, 2021/09/10
- Re: [PATCH 0/2] hmp: Unbreak "change vnc", tidy up set_password's doc, Markus Armbruster, 2021/09/17