[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 17/21] LoongArch Linux User Emulation
From: |
Song Gao |
Subject: |
Re: [PATCH v4 17/21] LoongArch Linux User Emulation |
Date: |
Wed, 8 Sep 2021 17:50:37 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Hi Richard,
On 09/05/2021 06:04 PM, Richard Henderson wrote:
>> +struct sigframe {
>> + uint32_t sf_ass[4]; /* argument save space for o32 */
>
> Surely there is no "o32" for loongarch?
>
Yes, qemu only support 64bit. but the kernel has 'o32'. Should we have to be
consistent with the kernel?
>> + uint32_t sf_code[2]; /* signal trampoline */
>
> Note that there are patches on-list for moving the signal trampoline off of
> the stack.
>
>> diff --git a/linux-user/loongarch64/termbits.h
>> b/linux-user/loongarch64/termbits.h
>> new file mode 100644
>> index 0000000..33e74ed
>> --- /dev/null
>> +++ b/linux-user/loongarch64/termbits.h
>> @@ -0,0 +1,229 @@
>> +#ifndef LINUX_USER_LOONGARCH_TERMBITS_H
>> +#define LINUX_USER_LOONGARCH_TERMBITS_H
>> +
>> +#define TARGET_NCCS 19
>
> Surely you should be using generic/termbits.h?
> OK.
> We will prefer not to merge a linux-user port that is not upstream, because
> the ABI may change in between. Can you provide a pointer to your kernel port
> in the meantime?
Latest kernel: https://github.com/loongson/linux/tree/loongarch-next
Song Gao
Thanks.
- [PATCH v4 15/21] target/loongarch: Add branch instruction translation, (continued)
- [PATCH v4 15/21] target/loongarch: Add branch instruction translation, Song Gao, 2021/09/02
- [PATCH v4 18/21] default-configs: Add loongarch linux-user support, Song Gao, 2021/09/02
- [PATCH v4 19/21] target/loongarch: Add target build suport, Song Gao, 2021/09/02
- [PATCH v4 21/21] scripts: add loongarch64 binfmt config, Song Gao, 2021/09/02
- [PATCH v4 16/21] target/loongarch: Add disassembler, Song Gao, 2021/09/02
- [PATCH v4 17/21] LoongArch Linux User Emulation, Song Gao, 2021/09/02