[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 04/12] job: Force-cancel jobs in a failed transaction
From: |
Hanna Reitz |
Subject: |
[PATCH v4 04/12] job: Force-cancel jobs in a failed transaction |
Date: |
Tue, 7 Sep 2021 14:42:37 +0200 |
When a transaction is aborted, no result matters, and so all jobs within
should be force-cancelled.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
job.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/job.c b/job.c
index 810e6a2065..e74d81928d 100644
--- a/job.c
+++ b/job.c
@@ -766,7 +766,12 @@ static void job_completed_txn_abort(Job *job)
if (other_job != job) {
ctx = other_job->aio_context;
aio_context_acquire(ctx);
- job_cancel_async(other_job, false);
+ /*
+ * This is a transaction: If one job failed, no result will matter.
+ * Therefore, pass force=true to terminate all other jobs as
quickly
+ * as possible.
+ */
+ job_cancel_async(other_job, true);
aio_context_release(ctx);
}
}
--
2.31.1
- [PATCH v4 00/12] mirror: Handle errors after READY cancel, Hanna Reitz, 2021/09/07
- [PATCH v4 06/12] jobs: Give Job.force_cancel more meaning, Hanna Reitz, 2021/09/07
- [PATCH v4 08/12] mirror: Use job_is_cancelled(), Hanna Reitz, 2021/09/07
- [PATCH v4 10/12] mirror: Stop active mirroring after force-cancel, Hanna Reitz, 2021/09/07
- [PATCH v4 11/12] mirror: Do not clear .cancelled, Hanna Reitz, 2021/09/07