[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/20] ppc/pnv: Add an assert when calculating the RAM dis
From: |
Greg Kurz |
Subject: |
Re: [PATCH v2 02/20] ppc/pnv: Add an assert when calculating the RAM distribution on chips |
Date: |
Fri, 3 Sep 2021 11:46:04 +0200 |
On Thu, 2 Sep 2021 15:09:10 +0200
Cédric Le Goater <clg@kaod.org> wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>
Reviewed-by: Greg Kurz <groug@kaod.org>
> v2: fixed assert value ...
>
> hw/ppc/pnv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 03c86508d2f7..71e45515f136 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -723,6 +723,8 @@ static uint64_t pnv_chip_get_ram_size(PnvMachineState
> *pnv, int chip_id)
> return QEMU_ALIGN_DOWN(ram_per_chip, 1 * MiB);
> }
>
> + assert(pnv->num_chips > 1);
> +
> ram_per_chip = (machine->ram_size - 1 * GiB) / (pnv->num_chips - 1);
> return chip_id == 0 ? 1 * GiB : QEMU_ALIGN_DOWN(ram_per_chip, 1 * MiB);
> }
- [PATCH v2 00/20] ppc/pnv: Extend the powernv10 machine, Cédric Le Goater, 2021/09/02
- [PATCH v2 13/20] ppc/pnv: Add support for PQ offload on PHB5, Cédric Le Goater, 2021/09/02
- [PATCH v2 11/20] ppc/xive2: Add support for notification injection on ESB pages, Cédric Le Goater, 2021/09/02
- [PATCH v2 15/20] pnv/xive2: Introduce new capability bits, Cédric Le Goater, 2021/09/02
- [PATCH v2 10/20] ppc/psi: Add support for StoreEOI and 64k ESB pages (POWER10), Cédric Le Goater, 2021/09/02
- [PATCH v2 19/20] pnv/xive2: Add support for automatic save&restore, Cédric Le Goater, 2021/09/02
- [PATCH v2 17/20] pnv/xive2: Add support XIVE2 P9-compat mode (or Gen1), Cédric Le Goater, 2021/09/02
- [PATCH v2 18/20] xive2: Add a get_config() handler for the router configuration, Cédric Le Goater, 2021/09/02
- [PATCH v2 20/20] pnv/xive2: Add support for 8bits thread id, Cédric Le Goater, 2021/09/02
- [PATCH v2 02/20] ppc/pnv: Add an assert when calculating the RAM distribution on chips, Cédric Le Goater, 2021/09/02
- [PATCH v2 03/20] ppc/xive2: Introduce a XIVE2 core framework, Cédric Le Goater, 2021/09/02
- [PATCH v2 04/20] ppc/xive2: Introduce a presenter matching routine, Cédric Le Goater, 2021/09/02
- [PATCH v2 01/20] docs/system: ppc: Update the URL for OpenPOWER firmware images, Cédric Le Goater, 2021/09/02
- [PATCH v2 07/20] ppc/pnv: Add POWER10 quads, Cédric Le Goater, 2021/09/02
- [PATCH v2 08/20] ppc/pnv: Add model for POWER10 PHB5 PCIe Host bridge, Cédric Le Goater, 2021/09/02
- [PATCH v2 09/20] ppc/pnv: Add a HOMER model to POWER10, Cédric Le Goater, 2021/09/02
- [PATCH v2 05/20] ppc/pnv: Add a XIVE2 controller to the POWER10 chip, Cédric Le Goater, 2021/09/02