[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/5] mirror-top-perms: Fix AbnormalShutdown path
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v4 4/5] mirror-top-perms: Fix AbnormalShutdown path |
Date: |
Thu, 2 Sep 2021 12:15:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 9/2/21 11:58 AM, Vladimir Sementsov-Ogievskiy wrote:
> 02.09.2021 12:40, Hanna Reitz wrote:
>> The AbnormalShutdown exception class is not in qemu.machine, but in
>> qemu.machine.machine. (qemu.machine.AbnormalShutdown was enough for
>> Python to find it in order to run this test, but pylint complains about
>> it.)
>>
>> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
>> ---
>> tests/qemu-iotests/tests/mirror-top-perms | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/qemu-iotests/tests/mirror-top-perms
>> b/tests/qemu-iotests/tests/mirror-top-perms
>> index 451a0666f8..2fc8dd66e0 100755
>> --- a/tests/qemu-iotests/tests/mirror-top-perms
>> +++ b/tests/qemu-iotests/tests/mirror-top-perms
>> @@ -47,7 +47,7 @@ class TestMirrorTopPerms(iotests.QMPTestCase):
>> def tearDown(self):
>> try:
>> self.vm.shutdown()
>> - except qemu.machine.AbnormalShutdown:
>> + except qemu.machine.machine.AbnormalShutdown:
>> pass
>> if self.vm_b is not None:
>>
>
> Hmm, interesting.. May be that bad that module has same name as subpackage?
Confusing indeed. Could this be improved?
- [PATCH v4 0/5] iotests/297: Cover tests/, Hanna Reitz, 2021/09/02
- [PATCH v4 1/5] iotests/297: Drop 169 and 199 from the skip list, Hanna Reitz, 2021/09/02
- [PATCH v4 2/5] migrate-bitmaps-postcopy-test: Fix pylint warnings, Hanna Reitz, 2021/09/02
- [PATCH v4 3/5] migrate-bitmaps-test: Fix pylint warnings, Hanna Reitz, 2021/09/02
- [PATCH v4 5/5] iotests/297: Cover tests/, Hanna Reitz, 2021/09/02
- [PATCH v4 4/5] mirror-top-perms: Fix AbnormalShutdown path, Hanna Reitz, 2021/09/02
Re: [PATCH v4 0/5] iotests/297: Cover tests/, Hanna Reitz, 2021/09/07