[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 03/15] python: Remove global pylint suppressions
From: |
John Snow |
Subject: |
[PATCH v3 03/15] python: Remove global pylint suppressions |
Date: |
Tue, 29 Jun 2021 17:43:11 -0400 |
These suppressions only apply to a small handful of places. Instead of
disabling them globally, disable them just in the cases where we
need. The design of the machine class grew quite organically with tons
of constructor and class instance variables -- there's little chance of
meaningfully refactoring it in the near term, so just suppress the
warnings for that class.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
---
python/qemu/machine/machine.py | 3 +++
python/qemu/machine/qtest.py | 2 ++
python/setup.cfg | 4 +---
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index b62435528e..e3345dfa1b 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -84,6 +84,7 @@ class QEMUMachine:
...
# vm is guaranteed to be shut down here
"""
+ # pylint: disable=too-many-instance-attributes, too-many-public-methods
def __init__(self,
binary: str,
@@ -111,6 +112,8 @@ def __init__(self,
@param console_log: (optional) path to console log file
@note: Qemu process is not started until launch() is used.
'''
+ # pylint: disable=too-many-arguments
+
# Direct user configuration
self._binary = binary
diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py
index 93700684d1..d6d9c6a34a 100644
--- a/python/qemu/machine/qtest.py
+++ b/python/qemu/machine/qtest.py
@@ -116,6 +116,8 @@ def __init__(self,
base_temp_dir: str = "/var/tmp",
socket_scm_helper: Optional[str] = None,
sock_dir: Optional[str] = None):
+ # pylint: disable=too-many-arguments
+
if name is None:
name = "qemu-%d" % os.getpid()
if sock_dir is None:
diff --git a/python/setup.cfg b/python/setup.cfg
index db1639c1f2..524789d6e0 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -87,9 +87,7 @@ ignore_missing_imports = True
# --enable=similarities". If you want to run only the classes checker, but have
# no Warning level messages displayed, use "--disable=all --enable=classes
# --disable=W".
-disable=too-many-arguments,
- too-many-instance-attributes,
- too-many-public-methods,
+disable=
[pylint.basic]
# Good variable names which should always be accepted, separated by a comma.
--
2.31.1
- [PATCH v3 00/15] Python: packaging cleanups, John Snow, 2021/06/29
- [PATCH v3 02/15] python: expose typing information via PEP 561, John Snow, 2021/06/29
- [PATCH v3 01/15] python/qom: Do not use 'err' name at module scope, John Snow, 2021/06/29
- [PATCH v3 03/15] python: Remove global pylint suppressions,
John Snow <=
- [PATCH v3 04/15] python: Re-lock pipenv at *oldest* supported versions, John Snow, 2021/06/29
- [PATCH v3 05/15] python: README.rst touchups, John Snow, 2021/06/29
- [PATCH v3 07/15] python: rename 'venv-check' target to 'check-pipenv', John Snow, 2021/06/29
- [PATCH v3 08/15] python: update help text for check-tox, John Snow, 2021/06/29
- [PATCH v3 06/15] python: Add no-install usage instructions, John Snow, 2021/06/29
- [PATCH v3 09/15] python: Fix .PHONY Make specifiers, John Snow, 2021/06/29
- [PATCH v3 10/15] python: only check qemu/ subdir with flake8, John Snow, 2021/06/29
- [PATCH v3 11/15] python: add 'make check-dev' invocation, John Snow, 2021/06/29