qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 8/9] target/nios2: Inline handle_instruction


From: Richard Henderson
Subject: Re: [PATCH v3 8/9] target/nios2: Inline handle_instruction
Date: Tue, 29 Jun 2021 06:53:46 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 6/29/21 2:27 AM, Peter Maydell wrote:
On Mon, 28 Jun 2021 at 23:13, Richard Henderson
<richard.henderson@linaro.org> wrote:

Move handle_instruction into nios2_tr_translate_insn
as the only caller.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/nios2/translate.c | 66 +++++++++++++++++++---------------------
  1 file changed, 31 insertions(+), 35 deletions(-)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Side note: I think we could replace all the handling of dc->zero
by having load_gpr() return a tcg_constant_i32(0) for R_ZERO,
which then never needs freeing. (We never try to write back
to what we get from load_gpr().)

Quite right.  There are several targets that could benefit from that 
simplification.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]