[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] block: drop BlockDriverState::read_only
|
From: |
Kevin Wolf |
|
Subject: |
Re: [PATCH v2 0/3] block: drop BlockDriverState::read_only |
|
Date: |
Mon, 31 May 2021 16:45:50 +0200 |
Am 27.05.2021 um 17:40 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all!
>
> The field duplicates information in .open_flags. We have to carefully
> sync these two fields everywhere. It's simple to introduce a bug by
> forgetting it.
>
> Let's drop the field, and fix users to call bdrv_is_read_only() and
> bdrv_is_writable() instead.
>
> v2:
> 01: write "update_header =\n..." in one line
> 03: only change BlockBackendRootState, don't touch side logic
Thanks, applied to the block branch.
Kevin