[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 18/26] DAX/unmap: virtiofsd: Add VHOST_USER_SLAVE_FS_IO
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [PATCH v3 18/26] DAX/unmap: virtiofsd: Add VHOST_USER_SLAVE_FS_IO |
|
Date: |
Thu, 27 May 2021 18:31:51 +0100 |
|
User-agent: |
Mutt/2.0.7 (2021-05-04) |
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> On Wed, Apr 28, 2021 at 12:00:52PM +0100, Dr. David Alan Gilbert (git) wrote:
> > + close(fd);
>
> I looked back at the hw/virtio/vhost-user.c slave channel code and it
> closes fds for us. Looks like this close(2) call should be removed, but
> please double-check in case I missed something.
Nice, I think you're right; I've deleted that close(fd)
> Stefan
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK