[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 3/6] tests/tcg/configure.sh: tweak quoting of target_compiler
From: |
Alex Bennée |
Subject: |
[PATCH v1 3/6] tests/tcg/configure.sh: tweak quoting of target_compiler |
Date: |
Thu, 27 May 2021 17:03:16 +0100 |
If you configure the host compiler with a multi-command stanza like:
--cc="ccache gcc"
then the configure.sh machinery falls over with confusion. Work around
this by ensuring we correctly quote so where we need a complete
evaluation we get it. Of course the has() check needs single variable
so we need to unquote that. This does mean it essentially checks that
just the ccache command exits but if we got past that step we still
check the compiler actually does something.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>
---
tests/tcg/configure.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
index ed6492ce59..aa7c24328a 100755
--- a/tests/tcg/configure.sh
+++ b/tests/tcg/configure.sh
@@ -222,10 +222,10 @@ for target in $target_list; do
got_cross_cc=no
- if eval test "x\${cross_cc_$arch}" != xyes; then
- eval "target_compiler=\${cross_cc_$arch}"
+ if eval test "x\"\${cross_cc_$arch}\"" != xyes; then
+ eval "target_compiler=\"\${cross_cc_$arch}\""
- if has "$target_compiler"; then
+ if has $target_compiler; then
if test "$supress_clang" = yes &&
$target_compiler --version | grep -qi "clang"; then
got_cross_cc=no
--
2.20.1
- [PATCH v1 0/6] testing/next queue (signal, meson, acceptance tags), Alex Bennée, 2021/05/27
- [PATCH v1 2/6] meson.build: fix cosmetics of compiler display, Alex Bennée, 2021/05/27
- [PATCH v1 3/6] tests/tcg/configure.sh: tweak quoting of target_compiler,
Alex Bennée <=
- [PATCH v1 1/6] tests/tcg: add a multiarch signals test to stress test signal delivery, Alex Bennée, 2021/05/27
- [PATCH v1 4/6] gitlab-ci: Convert check-dco/check-patch jobs to the 'rules' syntax, Alex Bennée, 2021/05/27
- [PATCH v1 5/6] tests/acceptance: tweak the tcg/kvm tests for virt, Alex Bennée, 2021/05/27
- [PATCH v1 6/6] tests/acceptance: tag various arm tests as TCG only, Alex Bennée, 2021/05/27