Re: [PATCH 00/11] Unified peripheral emulation for Renesas chips

[no-reply]

Patchew URL: 
20210527052122.97103-1-ysato@users.sourceforge.jp/">https://patchew.org/QEMU/20210527052122.97103-1-ysato@users.sourceforge.jp/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210527052122.97103-1-ysato@users.sourceforge.jp
Subject: [PATCH 00/11] Unified peripheral emulation for Renesas chips

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210527052122.97103-1-ysato@users.sourceforge.jp 
-> patchew/20210527052122.97103-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
0d61629 hw/rx: rx-gdbsim Add bootstrup for linux
5595fd4 hw/sh4: sh7750 use new hw modules.
f85d3d2 hw/sh4: sh7750 Add CPG.
9422b37 hw/rx: rx62n use new hw modules.
88d7ca2 hw/timer: Renesas 8bit timer.
afe51ff hw/rx: Add RX62N Clock generator
87c0b3e hw/timer: Remove renesas_cmt.
e0a4816 hw/timer: Remove sh_timer.
0f983ff hw/timer: Renesas TMU/CMT module.
a5ba8bb hw/char: remove sh_serial.
872e5de hw/char: Renesas SCI module.

=== OUTPUT BEGIN ===
1/11 Checking commit 872e5de1daf1 (hw/char: Renesas SCI module.)
2/11 Checking commit a5ba8bb0a18d (hw/char: remove sh_serial.)
3/11 Checking commit 0f983ff94436 (hw/timer: Renesas TMU/CMT module.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

total: 0 errors, 1 warnings, 752 lines checked

Patch 3/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/11 Checking commit e0a48164d14f (hw/timer: Remove sh_timer.)
5/11 Checking commit 87c0b3e06524 (hw/timer: Remove renesas_cmt.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
deleted file mode 100644

total: 0 errors, 1 warnings, 7 lines checked

Patch 5/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/11 Checking commit afe51ff3750d (hw/rx: Add RX62N Clock generator)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 561 lines checked

Patch 6/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/11 Checking commit 88d7ca270dfb (hw/timer: Renesas 8bit timer.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
deleted file mode 100644

total: 0 errors, 1 warnings, 626 lines checked

Patch 7/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/11 Checking commit 9422b37a5c14 (hw/rx: rx62n use new hw modules.)
9/11 Checking commit f85d3d235566 (hw/sh4: sh7750 Add CPG.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#98: 
new file mode 100644

total: 0 errors, 1 warnings, 616 lines checked

Patch 9/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/11 Checking commit 5595fd490cbc (hw/sh4: sh7750 use new hw modules.)
ERROR: space required before the open parenthesis '('
#88: FILE: hw/sh4/sh7750.c:819:
+    switch(feat) {

ERROR: braces {} are necessary for all arms of this statement
#105: FILE: hw/sh4/sh7750.c:836:
+    if (tei_source)
[...]

ERROR: braces {} are necessary for all arms of this statement
#107: FILE: hw/sh4/sh7750.c:838:
+    if (bri_source)
[...]

ERROR: code indent should never use tabs
#142: FILE: hw/sh4/sh7750.c:916:
+^I^Is->intc.irqs[TMU2_TICPI], cpg);$

ERROR: code indent should never use tabs
#157: FILE: hw/sh4/sh7750.c:937:
+^I^I    NULL, NULL, cpg);$

total: 5 errors, 0 warnings, 153 lines checked

Patch 10/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/11 Checking commit 0d616299f2f2 (hw/rx: rx-gdbsim Add bootstrup for linux)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210527052122.97103-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message">http://patchew.org/logs/20210527052122.97103-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com