Re: [PATCH v2 1/1] yank: Unregister function when using TLS migration

[Peter Xu]

On Wed, May 26, 2021 at 07:16:16PM -0300, Leonardo Bras wrote:
> After yank feature was introduced, whenever migration is started using TLS,
> the following error happens in both source and destination hosts:
> 
> (qemu) qemu-kvm: ../util/yank.c:107: yank_unregister_instance:
> Assertion `QLIST_EMPTY(&entry->yankfns)' failed.
> 
> This happens because of a missing yank_unregister_function() when using
> qio-channel-tls.
> 
> Fix this by also allowing TYPE_QIO_CHANNEL_TLS object type to perform
> yank_unregister_function() in channel_close() and multifd_load_cleanup().
> 
> Fixes: 50186051f ("Introduce yank feature")
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1964326
> Signed-off-by: Leonardo Bras <leobras.c@gmail.com>

Assuming you'll post a v3 soon trying to drop all references to ioc->master as
we've discussed. Meanwhile it should possibly be b5eea99ec2f ("migration: Add
yank feature", 2021-01-13) for the "fixes:"?

-- 
Peter Xu