Re: [RFC PATCH 11/15] exec/cpu: Make address_space_init/reloading_memory_map target agnostic

[Philippe Mathieu-Daudé]

On 5/26/21 9:01 PM, Richard Henderson wrote:
> On 5/17/21 4:55 AM, Philippe Mathieu-Daudé wrote:
>> cpu_address_space_init() and cpu_reloading_memory_map() don't
>> have to be target specific. Remove this limitation to be able
>> to build softmmu/cpus.c once for all targets.
>>
>> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
>> ---
>>   include/exec/cpu-common.h | 23 +++++++++++++++++++++++
>>   include/exec/exec-all.h   | 25 -------------------------
>>   2 files changed, 23 insertions(+), 25 deletions(-)
> 
> It's not clear to me why the declarations moved file, instead of just
> droppig the surrounding ifdef.

hwaddr is target-specific, cpu_address_space_init don't uses it.

softmmu/cpus.c is target-agnostic but uses cpu_address_space_init().

Similarly with cpu_reloading_memory_map() in softmmu/physmem.c.

> If there's a good reason, fine, but the reason belongs in the commit
> message.

OK, I'll mention hwaddr.