RE: [PATCH v6 03/13] virtio-gpu: Add udmabuf helpers

[Kasireddy, Vivek]

Hi Gerd,

>   Hi,
> 
> > +#ifdef CONFIG_LINUX
> 
> Seems wee need "#if defined(CONFIG_LINUX) && defined(F_GET_SEALS)" here
> to cover old linux versions.  I see some build failures in gitlab CI due to
> F_GET_SEALS not being defined (crypto-old-nettle for example).
[Kasireddy, Vivek] Instead, I am planning to remove the ifdef and add a file in 
stubs
with the pixman dependency like you suggested. For seals, I think I could just 
include
qemu/memfd.h that has a definition for F_GET_SEALS.

> 
> > +#include <sys/fcntl.h>
> 
> gitlab ci (build-system-alpine):
> 
> /usr/include/sys/fcntl.h:1:2: error: #warning redirecting incorrect #include 
> <sys/fcntl.h> to
> <fcntl.h> [-Werror=cpp]
>     1 | #warning redirecting incorrect #include <sys/fcntl.h> to <fcntl.h>
[Kasireddy, Vivek] Ok, I'll replace sys/fcntl.h with just fcntl.h

> 
> Otherwise series looks good and survived basic testing.
[Kasireddy, Vivek] Will send a v7 that would address the above issues.

Thanks,
Vivek
> 
> take care,
>   Gerd