Re: [PATCH v3 2/3] tests/qtest/virtio-scsi-test: add unmap large LBA with 4k blocks test

[Paolo Bonzini]

On 25/05/21 21:46, Kit Westneat wrote:
> +static void *virtio_scsi_setup_4k(GString *cmd_line, void *arg)
> +{
> +    g_string_append(cmd_line,
> +                    " -drive file=blkdebug::null-co://,"
> +                    "file.image.read-zeroes=on,"
> +                    "if=none,id=dr1,format=raw,file.blocksize=4k "
> +                    "-device scsi-hd,drive=dr1,lun=0,scsi-id=1");

Instead of having patches 1+3, I think it's enough to use "-device 
scsi-hd,...,logical_block_size=4096".

Thanks,

Paolo