Re: [PATCH v7 17/31] python: add pylint to pipenv

[Vladimir Sementsov-Ogievskiy]

26.05.2021 03:24, John Snow wrote:
> We are specifying >= pylint 2.8.x for several reasons:
>
> 1. For setup.cfg support, added in pylint 2.5.x
> 2. To specify a version that has incompatibly dropped
>     bad-whitespace checks (2.6.x)
> 3. 2.7.x fixes "unsubscriptable" warnings in Python 3.9
> 4. 2.8.x adds a new, incompatible 'consider-using-with'
>     warning that must be disabled in some cases.
>     These pragmas cause warnings themselves in 2.7.x.
>
> Signed-off-by: John Snow <jsnow@redhat.com>

Not sure how to review this one, numbers looks like numbers, hashes looks like 
hashes, so it's OK :)

I've tried to regenerate Pipfile.lock from venv, and I see that new generated 
Pipfile.lock has same hashes..

Still, new generated Pipfile.lock has some additional entries: appdirs, 
distlib, filelock, importlib-resources, packaging, pluggy, py, pyparsing, six, 
tox, virtualenv.. Not sure is it OK.

Another differencies are:

for importlib-metadata:

 "markers": "python_version < '3.8'"   ->   "markers": "python_version < '3.8' and 
python_version < '3.8'"

(looks like a bug in pipenv, isn't it)

for zipp:
  
 "markers": "python_version >= '3.6'"  ->   "markers": "python_version < '3.10'"


The thing I hope is: we will not have commits like this one often..


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>


--
Best regards,
Vladimir