qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] configure: Do not add --warn-common to the linker flags


From: Richard Henderson
Subject: Re: [RFC PATCH] configure: Do not add --warn-common to the linker flags anymore
Date: Tue, 25 May 2021 16:22:40 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/25/21 4:11 AM, Thomas Huth wrote:
We are compiling with -fno-common since commit 4c288acbd6 ("configure:
Always build with -fno-common"), so --warn-common (which had been added
in commit 49237acdb725e in 2008 already) should not be necessary anymore
nowadays.

Signed-off-by: Thomas Huth<thuth@redhat.com>
---
  Marked as RFC since I'm not 100% sure whether I'm missing here something...
  but IMHO the --warn-common does not buy us anything if we also compile
  with -fno-common...

I agree.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]