[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/6] tests/qtest/pflash-cfi02-test: Avoid potential integer overf
From: |
Peter Maydell |
Subject: |
[PATCH 4/6] tests/qtest/pflash-cfi02-test: Avoid potential integer overflow |
Date: |
Tue, 25 May 2021 14:44:56 +0100 |
Coverity points out that we calculate a 64-bit value using 32-bit
arithmetic; add the cast to force the multiply to be done as 64-bits.
(The overflow will never happen with the current test data.)
Fixes: Coverity CID 1432320
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
tests/qtest/pflash-cfi02-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/pflash-cfi02-test.c b/tests/qtest/pflash-cfi02-test.c
index 60db81a3a2b..6168edc821a 100644
--- a/tests/qtest/pflash-cfi02-test.c
+++ b/tests/qtest/pflash-cfi02-test.c
@@ -406,7 +406,7 @@ static void test_geometry(const void *opaque)
for (int region = 0; region < nb_erase_regions; ++region) {
for (uint32_t i = 0; i < c->nb_blocs[region]; ++i) {
- uint64_t byte_addr = i * c->sector_len[region];
+ uint64_t byte_addr = (uint64_t)i * c->sector_len[region];
g_assert_cmphex(flash_read(c, byte_addr), ==, bank_mask(c));
}
}
--
2.20.1
- [PATCH 0/6] tests: Fix some minor Coverity issues, Peter Maydell, 2021/05/25
- [PATCH 1/6] tests/qtest/bios-tables-test: Check for dup2() failure, Peter Maydell, 2021/05/25
- [PATCH 2/6] tests/qtest/e1000e-test: Check qemu_recv() succeeded, Peter Maydell, 2021/05/25
- [PATCH 4/6] tests/qtest/pflash-cfi02-test: Avoid potential integer overflow,
Peter Maydell <=
- [PATCH 3/6] tests/qtest/hd-geo-test: Fix checks on mkstemp() return value, Peter Maydell, 2021/05/25
- [PATCH 5/6] tests/qtest/tpm-tests: Remove unnecessary NULL checks, Peter Maydell, 2021/05/25
- [PATCH 6/6] tests/unit/test-vmstate: Assert that dup() and mkstemp() succeed, Peter Maydell, 2021/05/25