Re: [PATCH v1 7/8] gdbstub: tidy away reverse debugging check into function

[Philippe Mathieu-Daudé]

Hi Alex,

On 5/20/21 7:43 PM, Alex Bennée wrote:
> In theory we don't need an actual record/replay to enact reverse
> debugging on a purely deterministic system (i.e one with no external
> inputs running under icount). Tidy away the logic into a little
> function.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  gdbstub.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index 84ce770a04..52bde5bdc9 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -465,6 +465,15 @@ int use_gdb_syscalls(void)
>      return gdb_syscall_mode == GDB_SYS_ENABLED;
>  }
>  
> +static bool stub_can_reverse(void)

Do you mind renaming it gdbstub_can_reverse()?

Otherwise:

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>