[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to Lin
From: |
Willian Rampazzo |
Subject: |
Re: [PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest |
Date: |
Mon, 24 May 2021 15:54:46 -0300 |
On Mon, May 24, 2021 at 3:30 PM Willian Rampazzo <wrampazz@redhat.com> wrote:
>
> On Tue, May 4, 2021 at 1:01 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> >
> > Hi Wainer,
> >
> > On 5/4/21 12:43 AM, Wainer dos Santos Moschetta wrote:
> > > The Sun4uMachine class inherit from LinuxKernelTest to effectively only
> > > use
> > > the KERNEL_COMMON_COMMAND_LINE attribute. This change remove that unneeded
> > > dependency, making Sun4uMachine self-content.
> >
> > It is odd because the test boots a Linux kernel...
> >
> > Once you added ConsoleMixIn, LinuxKernelTest is left with
> > 2 methods related to archive extraction. Not particularly
> > specific to Linux kernel. Beside, shouldn't these methods
> > be provided by Avocado directly, by avocado.utils.archive
> > and avocado.utils.software_manager.backends?
>
> Indeed, it makes a lot of sense to have those two methods inside the
> Avocado utilities. I opened an issue on the Avocado side to track
> that: https://github.com/avocado-framework/avocado/issues/4610.
Beraldo reminded me there is already an issue to handle this:
https://github.com/avocado-framework/avocado/issues/3549.
- Re: [PATCH 1/7] tests/acceptance: Introduce the ConsoleMixIn class, (continued)
- [PATCH 2/7] tests/acceptance: Move exec_command to ConsoleMixIn, Wainer dos Santos Moschetta, 2021/05/03
- [PATCH 3/7] tests/acceptance: Move exec_command_and_wait_for_pattern to ConsoleMixIn, Wainer dos Santos Moschetta, 2021/05/03
- [PATCH 5/7] tests/acceptance: replay_kernel: Remove unused wait_for_console_pattern, Wainer dos Santos Moschetta, 2021/05/03
- [PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest, Wainer dos Santos Moschetta, 2021/05/03
- Re: [PATCH 4/7] tests/acceptance: Sun4uMachine: Remove dependency to LinuxKernelTest, Willian Rampazzo, 2021/05/24
- [PATCH 7/7] tests/acceptance: Move _console_interaction to ConsoleMixIn, Wainer dos Santos Moschetta, 2021/05/03
- [PATCH 6/7] tests/acceptance: Move wait_for_console_pattern to ConsoleMixIn, Wainer dos Santos Moschetta, 2021/05/03
- Re: [PATCH 0/7] tests/acceptance: Introducing the ConsoleMixIn, Willian Rampazzo, 2021/05/24