qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/3] qemu-config: parse configuration files to a QDict


From: Paolo Bonzini
Subject: Re: [PATCH v3 1/3] qemu-config: parse configuration files to a QDict
Date: Fri, 21 May 2021 18:42:19 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 21/05/21 18:09, Kevin Wolf wrote:
+    qemu_opts_absorb_qdict(opts, qdict, errp);
+    if (errp) {
This doesn't do what you wanted.

*errp would be be better, but you also need ERRP_GUARD() then.

The other option would be using the return value of
qemu_opts_absorb_qdict().


Uff, you're absolutely right.  I'm a trainwreck today...

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]