[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/11] ui/spice-display: check NULL pointer in interface_release_r
From: |
Gerd Hoffmann |
Subject: |
[PULL 02/11] ui/spice-display: check NULL pointer in interface_release_resource() |
Date: |
Fri, 21 May 2021 14:51:10 +0200 |
From: Mauro Matteo Cascella <mcascell@redhat.com>
Check rext.info to avoid potential NULL pointer dereference. A similar check
exists in interface_release_resource() in hw/display/qxl.c.
Reported-by: Yu Lu <ini.universe@gmail.com>
Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
Reviewed-by: Prasad J Pandit <pjp@fedoraproject.org>
Message-Id: <20210520105833.183160-1-mcascell@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/spice-display.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/ui/spice-display.c b/ui/spice-display.c
index d22781a23d06..f59c69882d91 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -561,6 +561,10 @@ static void interface_release_resource(QXLInstance *sin,
SimpleSpiceCursor *cursor;
QXLCommandExt *ext;
+ if (!rext.info) {
+ return;
+ }
+
ext = (void *)(intptr_t)(rext.info->id);
switch (ext->cmd.type) {
case QXL_CMD_DRAW:
--
2.31.1
- [PULL 00/11] Ui 20210521 patches, Gerd Hoffmann, 2021/05/21
- [PULL 01/11] vnc: spelling fix (enable->enabled), Gerd Hoffmann, 2021/05/21
- [PULL 02/11] ui/spice-display: check NULL pointer in interface_release_resource(),
Gerd Hoffmann <=
- [PULL 04/11] ui: add clipboard infrastructure, Gerd Hoffmann, 2021/05/21
- [PULL 05/11] ui: add clipboard documentation, Gerd Hoffmann, 2021/05/21
- [PULL 03/11] build: add separate spice-protocol config option, Gerd Hoffmann, 2021/05/21
- [PULL 06/11] ui/vdagent: core infrastructure, Gerd Hoffmann, 2021/05/21
- [PULL 07/11] ui/vdagent: add mouse support, Gerd Hoffmann, 2021/05/21
- [PULL 08/11] ui/vdagent: add clipboard support, Gerd Hoffmann, 2021/05/21
- [PULL 10/11] ui/gtk: move struct GtkDisplayState to ui/gtk.h, Gerd Hoffmann, 2021/05/21
- [PULL 11/11] ui/gtk: add clipboard support, Gerd Hoffmann, 2021/05/21
- [PULL 09/11] ui/vnc: clipboard support, Gerd Hoffmann, 2021/05/21
- Re: [PULL 00/11] Ui 20210521 patches, no-reply, 2021/05/21