[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections
|
From: |
John Snow |
|
Subject: |
Re: [PATCH 2/6] qapi/parser: Allow empty QAPIDoc Sections |
|
Date: |
Thu, 20 May 2021 18:23:56 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/20/21 10:42 AM, Markus Armbruster wrote:
First step is to find out how _end_section() can be called twice in a
row. It isn't in all of "make check". Hmm.
Ah, maybe not twice in a *row*. It does seem to be called when we have
an "empty section" sometimes, which arises from stuff like this:
Extension error:
/home/jsnow/src/qemu/docs/../qga/qapi-schema.json:1143:1: ending a
totally empty section
##
# @GuestExec:
# @pid: pid of child process in guest OS
#
# Since: 2.5
##
{ 'struct': 'GuestExec',
'data': { 'pid': 'int'} }
Without the newline there, it seems to get confused. There's a few like
this that could be fixed, but then some of the test cases break too.
No appetite for barking up this tree right now.
Can I fix the commit message and leave the patch in place? Maybe with a
#FIXME comment nearby?
--js
[PATCH 4/6] qapi/parser.py: enable mypy checks, John Snow, 2021/05/19
[PATCH 1/6] qapi/parser.py: remove unused check_args_section arguments, John Snow, 2021/05/19
[PATCH 5/6] qapi/parser.py: Silence too-few-public-methods warning, John Snow, 2021/05/19
[PATCH 6/6] qapi/parser.py: enable pylint checks, John Snow, 2021/05/19
[PATCH 3/6] qapi/parser.py: add type hint annotations (QAPIDoc), John Snow, 2021/05/19