qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/6] gitlab-ci: Adapt JOBS variable for FreeBSD runners


From: Wainer dos Santos Moschetta
Subject: Re: [PATCH v3 2/6] gitlab-ci: Adapt JOBS variable for FreeBSD runners
Date: Thu, 20 May 2021 15:18:10 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

Hi,

On 5/19/21 3:45 PM, Philippe Mathieu-Daudé wrote:
'nproc' is not available on FreeBSD:

   $ JOBS=$(expr $(nproc) + 1)
   bash: line 119: nproc: command not found
   expr: syntax error

Instead, use 'sysctl -n hw.ncpu'.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
  .gitlab-ci.d/buildtest-template.yml | 12 +++++++++++-
  1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/buildtest-template.yml 
b/.gitlab-ci.d/buildtest-template.yml
index 58b01744751..fe4f18595ac 100644
--- a/.gitlab-ci.d/buildtest-template.yml
+++ b/.gitlab-ci.d/buildtest-template.yml
@@ -1,6 +1,16 @@
  .environment_variables_template:
    before_script:
-    - JOBS=$(expr $(nproc) + 1)
+    - if
+        test $(uname) = "FreeBSD"
+        ;
+      then
+        JOBS=$(sysctl -n hw.ncpu)
+        ;
+      else
+        JOBS=$(expr $(nproc) + 1)
+        ;
+      fi
+    - echo "=== Using $JOBS simultaneous jobs ==="

It has grown to beyond variables definitions. I suggest to rename it to something like `.before_script_template` (pure creativity, see?).

- Wainer

.native_build_job_template:
    stage: build




reply via email to

[Prev in Thread] Current Thread [Next in Thread]