[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/virtio: Have virtio_bus_get_vdev_bad_features() return 64
|
From: |
Cornelia Huck |
|
Subject: |
Re: [PATCH] hw/virtio: Have virtio_bus_get_vdev_bad_features() return 64-bit value |
|
Date: |
Thu, 20 May 2021 12:52:00 +0200 |
On Thu, 20 May 2021 12:28:22 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> In commit 019a3edbb25 ("virtio: make features 64bit wide") we
> increased the 'features' field to 64-bit, but forgot to update
> the virtio_bus_get_vdev_bad_features() helper. The 'bad features'
> are truncated to 32-bit. The virtio_net_bad_features() handler
> from the virtio-net devices is potentially affected.
>
> Have the virtio_bus_get_vdev_bad_features() helper return the
> full 64-bit value.
>
> Cc: qemu-stable@nongnu.org
> Fixes: 019a3edbb25 ("virtio: make features 64bit wide")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> include/hw/virtio/virtio-bus.h | 2 +-
> hw/virtio/virtio-bus.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>