Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors

From:	John Snow
Subject:	Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors
Date:	Wed, 19 May 2021 13:17:56 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/19/21 3:01 AM, Markus Armbruster wrote:

In commit f5d4361cda "qapi/source.py: add type hint annotations", I
believe.

Hmm, this commit actually fixes incorrect typing, doesn't it?


Yes.

It just wasn't caught because this file wasn't being checked yet. Itried to avoid this for a long time by making sure I tested my fullconversion stack after every rebase, but it got too cumbersome.

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 00/21] qapi: static typing conversion, pt5a, John Snow, 2021/05/11
- [PATCH v2 01/21] qapi/parser: Don't try to handle file errors, John Snow, 2021/05/11
  - Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors, Markus Armbruster, 2021/05/18
    - Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors, John Snow, 2021/05/18
    - Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors, Markus Armbruster, 2021/05/19
    - Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors, John Snow <=
    - Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors, John Snow, 2021/05/19
    - Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors, John Snow, 2021/05/18
    - Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors, Markus Armbruster, 2021/05/19
- [PATCH v2 06/21] qapi/parser: enforce all top-level expressions must be dict in _parse(), John Snow, 2021/05/11
- [PATCH v2 02/21] qapi: Add test for nonexistent schema file, John Snow, 2021/05/11
- [PATCH v2 03/21] qapi/source: Remove line number from QAPISourceInfo initializer, John Snow, 2021/05/11
- [PATCH v2 07/21] qapi/parser: assert object keys are strings, John Snow, 2021/05/11
- [PATCH v2 05/21] qapi/parser: Assert lexer value is a string, John Snow, 2021/05/11
  - Re: [PATCH v2 05/21] qapi/parser: Assert lexer value is a string, Markus Armbruster, 2021/05/18
    - Re: [PATCH v2 05/21] qapi/parser: Assert lexer value is a string, John Snow, 2021/05/18

Prev by Date: Re: [PATCH v2 0/2] target/i386: Make sure that vsyscall's tb->size != 0
Next by Date: Re: [PATCH 4/4] aspeed: sonorapass: enable pca954x muxes
Previous by thread: Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors
Next by thread: Re: [PATCH v2 01/21] qapi/parser: Don't try to handle file errors
Index(es):
- Date
- Thread