qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] vl: add -object support back into -readconfig


From: Paolo Bonzini
Subject: Re: [PATCH 0/3] vl: add -object support back into -readconfig
Date: Wed, 19 May 2021 16:46:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 19/05/21 15:58, Kevin Wolf wrote:
Am 18.05.2021 um 17:40 hat Paolo Bonzini geschrieben:
LXD developers have reported that [object] stanzas have stopped
working in configuration files.

The problem is that QEMU 6.0 switched the creation of objects from
qemu_opts_foreach to a bespoke QTAILQ, in preparation for supporting
JSON syntax in -object.  Entries from the configuration file however
do not go through object_option_parse, and are thus lost.  Of the many
fixes that are possible, I chose one that is slightly more invasive but
more consistent with the plans for keyval-ification of options such as
-M and -accel.

-set was also broken by the same change, but for simplicity I chose
not to add it back yet.  However, this series will report the
breakage instead of failing silently.

The first two patches of this series are thus a reduced version of
20210513162901.1310239-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20210513162901.1310239-1-pbonzini@redhat.com/
([PATCH 00/14] vl: compound properties for machines and accelerators),
with the -set infrastructure removed.  The third is very simple and
uses the newly-provided hooks to parse objects from configuration files.

Looks like this is
Based-on: <20210518131542.2941207-1-pbonzini@redhat.com>

Just context, but yes it is.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]